fix(record): retry unparsable L1 extraction output#190
Open
RerankerGuo wants to merge 1 commit into
Open
Conversation
Collaborator
|
Retrying on parse failure is a pragmatic improvement for L1 extraction reliability. We appreciate the care taken to not retry valid empty results. We'll review it internally. |
Signed-off-by: Ziyang Guo <121015044+RerankerGuo@users.noreply.github.com>
RerankerGuo
force-pushed
the
fix/l1-extraction-parse-retry
branch
from
5595963 to
d120268
Compare
YOMXXX
approved these changes
Jul 9, 2026
YOMXXX
left a comment
YOMXXX
left a comment
Contributor
There was a problem hiding this comment.
Approved after local verification. This is the canonical #115 fix for retrying unparsable L1 extraction output once while preserving valid empty [] responses.
Verified locally:
- COREPACK_ENABLE_AUTO_PIN=0 pnpm vitest run src/core/record/l1-extractor.test.ts
- COREPACK_ENABLE_AUTO_PIN=0 pnpm test
- COREPACK_ENABLE_AUTO_PIN=0 pnpm build
- git diff --check
Note: local Node is v22.14.0 while package.json wants >=22.16.0, so pnpm prints an engine warning, but all commands passed.
This was referenced Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description | 描述
Retry L1 extraction once when the model returns output that cannot be parsed as the required JSON array.
[]) as-is and does not retry them.Related Issue | 关联 Issue
Fix #115
Change Type | 修改类型
Self-test Checklist | 自测清单
Additional Notes | 其他说明
Verified with
npx vitest run src/core/record/l1-extractor.test.ts,npm test, andnpm run buildusing Node v24.15.0.